Not if you return TRUE;

I hope this patch improve performace on applications using bonoboui.

Benoît Dejean: I free l_closures at the end of the function.

Lee Willis: I found the patch easier to implement in bonobo and I didn’t know if I should forbid the addition of the same accelerator in GTK, though it looks odd, I know.

I can’t think of any reason why it would ever be valid to add the same accelerator to a widget multiple times?

Was there a particular reason this got fixed in bonobo, and not lower down in GTK?

+ if (n_entries)
+ for (l_tmp = l_closures; l_tmp; l_tmp = l_tmp->next)
+ for (i=0; idata)
+ return TRUE;
+
+ g_list_free (l_closures);
+
+ return FALSE;
+}

you forgot to free l_closures, didn’t you ?

This is only a fix for Evo, right? Setting accelerators in Gtk+ is still (relatively) slow, it sounds like.